81.4 is evil

Tuesday, January 2. 2007

I know many of you all know pretty well that floating point precision and computers don't play nicely with each other. I think I learned about it in the first book on 'C' I ever read, but I had never really been bitten by it until today. I was working with a piece of code today at the office that was throwing an error saying two values weren't zeroing out when they clearly should have been. I narrowed down the problem and after a bit of time decided that 81.4 is a terrible, terrible number. For example:

<?php
$total = 100 - 81.4;
//$total should be 18.6
echo "18.6 == {$total}? " .
($total == 18.6 ? 'yes' : 'no') .
"\n";
var_dump(18.6 - $total);
?>

So, let that be a lesson to us all. No matter how simple the calculation, don't blindly trust floats.

Posted by Mike Lively in PHP at 22:52 | Comments (7) | Trackbacks (0)

Trackbacks

Trackback specific URI for this entry

No Trackbacks

Comments

Display comments as (Linear | Threaded)

As any other guy I knew about floating point precision, but I always thought that it could only lose precision in the least significant digits, numerous digits after the decimal point and that it would only happen in inextricably complicated and rare situations. Now that I've run your very small and simple snippet I'm blown off.

Thanks for sharing that insightful piece of information, now you've increased my paranoia by at least 7.105427357601E15 percents

#1 Hubert Roksor (Homepage) on 2007-01-02 23:57 (Reply)

Rounding the values kinda sorts the problem ... but yes it is really bad :/

#1.1 Regin (Homepage) on 2007-01-03 03:22 (Reply)

This is bad!

#2 Lars Pohlmann (Homepage) on 2007-01-03 02:40 (Reply)

same here:
$total = 100 - 81.3;
print (18.7 - $total);

or here:
$total = 100 - 80.2;
print (19.8 - $total);

even in VB.

#2.1 Lars Pohlmann (Homepage) on 2007-01-03 02:56 (Reply)

use the bcmath library : http://www.php.net/manual/en/ref.bc.php

$truetotal = (float) bcadd('100', '-81.4', 1); 
 
echo "18.6 == {$truetotal}? " . 
($truetotal === 18.6 ? 'yes' : 'no') . 
"\n"; 
 
var_dump(18.6 - $truetotal);

output => 18.6 == 18.6? yes

#3 alex debril on 2007-01-03 06:17 (Reply)

If you don't have the bcmath php extension installed work out the values in cents first.

#4 Jacques Marneweck (Homepage) on 2007-01-03 18:12 (Reply)

I've ported a part of the Weka Data Mining Utils class that is used in all the classes when numerical comparisons are made. It addresses your concerns by adding a tolerance factor to all comparisons.

Here is a link to the relevant blog entry:

http://www.phpmath.com/home?op=perm&nid=53

Comments currently turned off as I don't have time right now to deal with spambots.

#5 Paul Meagher (Homepage) on 2007-01-04 10:17 (Reply)

Add Comment

Name
Email
Homepage
In reply to
Comment	BBCode format allowed Standard emoticons like :-) and ;-) are converted to images. E-Mail addresses will not be displayed and will only be used for E-Mail notifications To prevent automated Bots from commentspamming, please enter the string you see in the image below in the appropriate input box. Your comment will only be submitted if the strings match. Please ensure that your browser supports and accepts cookies, or your comment cannot be verified correctly. Enter the string from the spam-prevention image above: You can use [geshi lang=lang_name [,ln={y\|n}]][/lang] tags to embed source code snippets
	Remember Information? Subscribe to this entry

Paying for the Site

Quicksearch

Daily Reads

adam trachtenberg
Ben Ramsey
Chris Shiflett
Dynamically Typed (Harry Fuecks)
george schlossnagle
John Coggeshall
John Lim
Marco Tabini
PHP Application Tools
PHPCommunity.org
Planet PHP
Sebastian Bergmann
Sklar
The PHP WTF
Tobias Schlitt
Tom Sommer
Wez Furlong